[PATCH] Fix build warnings in aer.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Mike Qiu <qiudayu@xxxxxxxxxxxxxxxxxx>

build log:

In file included from include/ras/ras_event.h:11:0,
                 from drivers/ras/ras.c:13:
include/linux/aer.h:42:129: warning: â??struct pci_devâ??
declared inside parameter list [enabled by default]

include/linux/aer.h:42:129: warning: its scope is only
this definition or declaration, which is probably not
what you want [enabled by default]

include/linux/aer.h:46:130: warning: â??struct pci_devâ??
declared inside parameter list [enabled by default]

include/linux/aer.h:50:136: warning: â??struct pci_devâ??
declared inside parameter list [enabled by default]

include/linux/aer.h:57:14: warning: â??struct pci_devâ??
declared inside parameter list [enabled by default]

Signed-off-by: Mike Qiu <qiudayu@xxxxxxxxxxxxxxxxxx>
Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Tested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
Signed-off-by: Tony Luck <tony.luck@xxxxxxxxx>
---
 include/linux/aer.h | 2 ++
 1 file changed, 2 insertions(+)

Linus: The breakage that this fixes is actually only in linux-next,
but the commits that found this gap are already in the tip tree, so
hard to rebase to get this fix ahead of them to avoid a bisection gap.
But since this is so obvious - perhaps it can go into 3.16? If you
don't want it, I'll ask hpa to add it to the right topic branch in
tip so it is at least close to the commit that reveals the gap.

diff --git a/include/linux/aer.h b/include/linux/aer.h
index 4dbaa70..c826d1c 100644
--- a/include/linux/aer.h
+++ b/include/linux/aer.h
@@ -11,6 +11,8 @@
 #define AER_FATAL			1
 #define AER_CORRECTABLE			2
 
+struct pci_dev;
+
 struct aer_header_log_regs {
 	unsigned int dw0;
 	unsigned int dw1;
-- 
1.8.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux