On 14 July 2014 10:52, Mohit KUMAR DCG <Mohit.KUMAR@xxxxxx> wrote: > - I think we should read regmap_*() and msleep() in continuation and so the comment above it > is valid for both the operations. Probably not, its not obvious why a msleep() is required after regmap_*(). > Otherwise we can add comment line for msleep() like: > /* Wait for SATA power domain on */ > /* Wait for SATA reset de-assert completion */ > > Similarily in *_exit routine: > /* Wait for SATA power domain off */ > /* Wait for SATA reset assert completion */ These makes sense. Will add them. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html