On 07/01/2014 01:16 AM, Vidya Sagar wrote: > commit 1a680b7c moved pcie_aspm_powersave_config_link() out of > pci_raw_set_power_state() to pci_set_power_state() which would enable > ASPM. But, with commit db288c9c, which re-introduced the following check > ./drivers/pci/pci.c: pci_set_power_state() > + /* Check if we're already there */ > + if (dev->current_state == state) > + return 0; > in pci_set_power_state(), call to pcie_aspm_powersave_config_link() is never > made leaving ASPM broken. > Fix it by not returning from when the above condition is true, rather, jump to > ASPM configuration code and exit from there eventually. Out of curiosity, was this patch tested by running an umodified mainline kernel on a Tegra device, or is this simply a port from our downstream kernel, without any additional upstream testing? -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
