On Sat, Apr 12, 2014 at 2:11 AM, Jason Gunthorpe <jgunthorpe@xxxxxxxxxxxxxxxxxxxx> wrote: > On Fri, Apr 11, 2014 at 11:10:59PM +0530, Srikanth Thokala wrote: > >> I see this error too on my setup (Xilinx PCIe Root Complex Driver), >> https://lkml.org/lkml/2014/3/3/183 > >> After digging into it, I see I need to override the API >> pcibios_get_phb_of_node() > > No, as I pointed out before, the DT node comes in through > pci_scan_root_bus: Thanks Jason for the advice, it is working. Srikanth > > +static struct pci_bus __init *xilinx_pcie_scan_bus(int nr, > + struct pci_sys_data *sys) > +{ > + struct xilinx_pcie_port *port = sys_to_pcie(sys); > + struct pci_bus *bus; > + > + if (port) { > + port->root_busno = sys->busnr; > + bus = pci_scan_root_bus(NULL, sys->busnr, &xilinx_pcie_ops, > ^^^^^^ > > You can't pass NULL here and have DT work properly. > > See http://www.spinics.net/lists/arm-kernel/msg312392.html > > Jason -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html