On Thu, 2 Jan 2014 16:12:52 -0700 Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote: > [+cc Jesse, Myron] > > On Fri, Dec 27, 2013 at 2:27 PM, Stephen Hemminger > <stephen@xxxxxxxxxxxxxxxxxx> wrote: > > > > My philosophy is unused code is dead code. > > And dead code is subject to bit rot and is likely source of bugs. > > Use it or lose it. > > > > Signed-off-by: Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx> > > This removes pci_enable_ido(), pci_enable_obff(), pci_enable_ltr(), > etc., which I think you added, Jesse. In principle I like the idea of > removing code that isn't being used. Of course, these might be used > by out-of-tree drivers, but I don't think we should go *too* far out > of our way to support them. > > Anybody have any objections to removing them? Obviously they'll still > be in the git history, so it would be trivial to resurrect them. No objections. If driver folks haven't yet found a use for them (and/or hw is scarce) there's no reason to keep these. -- Jesse Barnes, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
