Re: [PATCH 2/2] ACPI / PCI: remove an extra check from acpi_pci_irq_enable()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday, August 08, 2013 03:35:14 PM Heikki Krogerus wrote:
> acpi_isa_irq_to_gsi() will check if the irq is within
> accepted rage so there is no need to check it separately.
> 
> Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

Hi Bjorn,

Does this look OK to you?

Rafael


> ---
>  drivers/acpi/pci_irq.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c
> index 902ed1c..e71e7fa 100644
> --- a/drivers/acpi/pci_irq.c
> +++ b/drivers/acpi/pci_irq.c
> @@ -427,9 +427,7 @@ int acpi_pci_irq_enable(struct pci_dev *dev)
>  			return -ENOENT;
>  		}
>  
> -		/* Interrupt Line values above 0xF are forbidden */
> -		if ((dev->irq <= 0xF) &&
> -		    (acpi_isa_irq_to_gsi(dev->irq, &dev_gsi) == 0)) {
> +		if (acpi_isa_irq_to_gsi(dev->irq, &dev_gsi) == 0) {
>  			dev_warn(&dev->dev, "PCI INT %c: no GSI - using ISA IRQ %d\n",
>  				 pin_name(pin), dev->irq);
>  			acpi_register_gsi(&dev->dev, dev_gsi,
> 
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux