On Wed, Aug 07, 2013 at 11:13:54AM +0200, Thomas Petazzoni wrote:
> Dear Thierry Reding,
>
> On Thu, 25 Jul 2013 09:53:03 -0700, Thierry Reding wrote:
>
> > I just noticed two minor issues, see below.
> >
> > > diff --git a/arch/arm/include/asm/mach/pci.h b/arch/arm/include/asm/mach/pci.h
> > [...]
> > > @@ -36,6 +36,8 @@ struct hw_pci {
> > > resource_size_t start,
> > > resource_size_t size,
> > > resource_size_t align);
> > > + void (*add_bus)(struct pci_bus *bus);
> > > + void (*remove_bus)(struct pci_bus *bus);
> >
> > This hunk...
> >
> > > @@ -63,6 +65,8 @@ struct pci_sys_data {
> > > resource_size_t start,
> > > resource_size_t size,
> > > resource_size_t align);
> > > + void (*add_bus)(struct pci_bus *bus);
> > > + void (*remove_bus)(struct pci_bus *bus);
> > > void *private_data; /* platform controller private data */
> > > };
> >
> > and this one use inconsistent indentation (spaces instead of tabs).
>
> Hum, I must be missing something here. Looking at the patch you're
> quoting, and my code, I see one tab before 'void' in both cases, and
> spaces between 'void' and the (*function) in both cases.
>
> Am I missing something here?
Perhaps I should've said "alignment" instead of "indentation" to make it
more explicit. All other members use tabs to separate the data type and
the field name, while the lines that you add use spaces.
Thierry
Attachment:
pgpYYtj6mUPaw.pgp
Description: PGP signature
