Dear Thierry Reding,
On Thu, 25 Jul 2013 09:53:03 -0700, Thierry Reding wrote:
> I just noticed two minor issues, see below.
>
> > diff --git a/arch/arm/include/asm/mach/pci.h b/arch/arm/include/asm/mach/pci.h
> [...]
> > @@ -36,6 +36,8 @@ struct hw_pci {
> > resource_size_t start,
> > resource_size_t size,
> > resource_size_t align);
> > + void (*add_bus)(struct pci_bus *bus);
> > + void (*remove_bus)(struct pci_bus *bus);
>
> This hunk...
>
> > @@ -63,6 +65,8 @@ struct pci_sys_data {
> > resource_size_t start,
> > resource_size_t size,
> > resource_size_t align);
> > + void (*add_bus)(struct pci_bus *bus);
> > + void (*remove_bus)(struct pci_bus *bus);
> > void *private_data; /* platform controller private data */
> > };
>
> and this one use inconsistent indentation (spaces instead of tabs).
Hum, I must be missing something here. Looking at the patch you're
quoting, and my code, I see one tab before 'void' in both cases, and
spaces between 'void' and the (*function) in both cases.
Am I missing something here?
> > diff --git a/arch/arm/kernel/bios32.c b/arch/arm/kernel/bios32.c
> [...]
> > @@ -464,6 +478,8 @@ static void pcibios_init_hw(struct device *parent, struct hw_pci *hw,
> > sys->swizzle = hw->swizzle;
> > sys->map_irq = hw->map_irq;
> > sys->align_resource = hw->align_resource;
> > + sys->add_bus = hw->add_bus;
> > + sys->remove_bus = hw->remove_bus;
>
> And this one aligns the '=' sign, whereas none of the other assignments
> do.
Right, will be fixed as part of PATCHv7.
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
