On Thu, Jul 25, 2013 at 7:14 AM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote: > On Wed, Jul 24, 2013 at 10:59 AM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote: >> On Tue, Jul 23, 2013 at 5:10 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote: >>> On Tue, Jul 23, 2013 at 11:08 AM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote: >>>> Convert pciehp to be builtin only, with no module option. >>>> >>>> Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> >>>> --- >>>> drivers/pci/pcie/Kconfig | 5 +---- >>>> 1 file changed, 1 insertion(+), 4 deletions(-) >>>> >>>> diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig >>>> index 569f82f..3b94cfc 100644 >>>> --- a/drivers/pci/pcie/Kconfig >>>> +++ b/drivers/pci/pcie/Kconfig >>>> @@ -14,15 +14,12 @@ config PCIEPORTBUS >>>> # Include service Kconfig here >>>> # >>>> config HOTPLUG_PCI_PCIE >>>> - tristate "PCI Express Hotplug driver" >>>> + bool "PCI Express Hotplug driver" >>>> depends on HOTPLUG_PCI && PCIEPORTBUS >>> >>> HOTPLUG_PCI is still tristate, >>> >>> menuconfig HOTPLUG_PCI >>> tristate "Support for PCI Hotplug" >>> >>> >>> Can you make HOTPLUG_PCI to be built-in ? >> >> Is that necessary for this CONFIG_HOTPLUG_PCI_PCIE change? The config >> tools are smart enough to only offer CONFIG_HOTPLUG_PCI_PCIE as an >> option when CONFIG_HOTPLUG_PCI=y, so I'm not sure it's actually a >> problem yet. > > a little weird. > before this change normally > CONFIG_HOTPLUG_PCI=m, and CONFIG_HOTPLUG_PCI_PCIE=m. > > now if user may select > CONFIG_HOTPLUG_PCI=m, and CONFIG_HOTPLUG_PCI_PCIE=y > never test that if it is really work. Ooh, you're right! I tried CONFIG_HOTPLUG_PCI=m and CONFIG_HOTPLUG_PCI_PCIE=y, and config *allows* that and builds a working kernel (though pciehp doesn't actually work), even though I don't think menuconfig will actually generate that combination. I'll convert CONFIG_HOTPLUG_PCI to a bool as well. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
