On Tue, Jul 23, 2013 at 5:10 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote: > On Tue, Jul 23, 2013 at 11:08 AM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote: >> Convert pciehp to be builtin only, with no module option. >> >> Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> >> --- >> drivers/pci/pcie/Kconfig | 5 +---- >> 1 file changed, 1 insertion(+), 4 deletions(-) >> >> diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig >> index 569f82f..3b94cfc 100644 >> --- a/drivers/pci/pcie/Kconfig >> +++ b/drivers/pci/pcie/Kconfig >> @@ -14,15 +14,12 @@ config PCIEPORTBUS >> # Include service Kconfig here >> # >> config HOTPLUG_PCI_PCIE >> - tristate "PCI Express Hotplug driver" >> + bool "PCI Express Hotplug driver" >> depends on HOTPLUG_PCI && PCIEPORTBUS > > HOTPLUG_PCI is still tristate, > > menuconfig HOTPLUG_PCI > tristate "Support for PCI Hotplug" > > > Can you make HOTPLUG_PCI to be built-in ? Is that necessary for this CONFIG_HOTPLUG_PCI_PCIE change? The config tools are smart enough to only offer CONFIG_HOTPLUG_PCI_PCIE as an option when CONFIG_HOTPLUG_PCI=y, so I'm not sure it's actually a problem yet. > or to be more aggressive, just kill HOTPLUG_PCI as with HOTPLUG. Getting rid of CONFIG_HOTPLUG let us get rid of all the __devinit* markings, which helps avoid a whole class of bugs. That doesn't apply to CONFIG_HOTPLUG_PCI, of course. But if somebody wants to do the work and see if it's useful to remove CONFIG_HOTPLUG_PCI, I'm certainly willing to consider it. I'm sure most general-purpose distros will set CONFIG_HOTPLUG_PCI=y and CONFIG_HOTPLUG_PCI_PCIE=y, but I wouldn't be surprised if embedded folks still leave them both disabled. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
