On Monday, July 1, 2013 at 3:51 PM, Alexander Shiyan wrote: > > This adds a PCI Express port driver for the on-chip PCI Express port > > present on the i.MX6 SoC. It is based on the PCI Express driver available > > in the Freescale BSP. > > > > Signed-off-by: Sean Cross <xobs@xxxxxxxxxx (mailto:xobs@xxxxxxxxxx)> > ... > > +++ b/Documentation/devicetree/bindings/pci/imx6q-pcie.txt > > @@ -0,0 +1,20 @@ > > +* Freescale i.MX6Q PCI Express bridge > > + > > +Example (i.MX6Q) > > + pcie: pcie@01ffc000 { > > + compatible = "fsl,imx6q-pcie"; > > + reg = <0x01ffc000 0x4000>, > > + <0x01000000 0x100000>, > > + <0x01100000 0xe00000>, > > + <0x01f00000 0xfc000>; > > + interrupts = <0 122 0x04>; > > + clocks = <&clks 186>, <&clks 189>, <&clks 196>, > > + <&clks 198>, <&clks 144>; > > + clock-names = "sata_ref", "pcie_ref_125m", "lvds1_sel", > > + "lvds1", "pcie_axi"; > > + power-enable = <&gpio7 12 0>; > > + pcie-reset = <&gpio3 29 0>; > > > > Can this be replaced with regulator/reset API? I agree that power-enable might be better replaced with regulator API calls, and I'll rework this patch to incorporate a regulator. I hadn't heard of the reset API before, and I note in the documentation that it says: Reset signals for whole standalone chips are most likely better represented as GPIOs, although there are likely to be exceptions to this rule. This is a reset line going directly to a PCIe slot, which I think counts as a "standalone chip". > > + wake-up = <&gpio3 22 0>; > > + disable-endpoint = <&gpio2 16 0>; > > + }; > > > > --- -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
