On Tue, May 7, 2013 at 8:10 PM, Gavin Shan <shangw@xxxxxxxxxxxxxxxxxx> wrote: > On Wed, May 08, 2013 at 10:38:00AM +0800, Gavin Shan wrote: >>On Tue, May 07, 2013 at 03:21:42PM -0700, Yinghai Lu wrote: >>>On Tue, May 7, 2013 at 1:11 AM, Gavin Shan <shangw@xxxxxxxxxxxxxxxxxx> wrote: >>>> Yinghai, thanks for the updated patch. It's working well with (v1 #1 and v2 #2), which >>>> was applied on top of Ben's patch sent for review. The kernel log is attached in case >>>> you want double-check. >>>> >>>Yes, that works. >>> >>>I just sent v3, please test that. >>> >>>That should be less invasive for v3.10. As it will skip adding failed >>>resource to failed list when the resource is IORESOURCE_IO, and bus >>>does not have IORESOURCE_IO. >>> >> >>Yinghai, with all patches (5) applied on top of Ben's patchset for PowerPC. >>I still see failure to assign IO ports, which shouldn't be seen. Please >>check the attached kernel log. >> > > After digging for more, here's what happened: pci_bridge_check_ranges() checks > the specific bridge supports IO ports and set IORESOURCE_IO explicitly if that's > the case. Then in pbus_size_io(), we always have valid IO window from that specific > PCI bus and the corresponding resource of the P2P bridge will be added to "realloc_head". > That eventually cause assignment of IO ports and it's to failure because the root > PCI bus doesn't have IO port range. that is intentionally, pci 0001:02:01.0: BAR 7: can't assign io (size 0x1000) pci 0001:02:08.0: BAR 7: can't assign io (size 0x1000) pci 0001:02:09.0: BAR 7: can't assign io (size 0x1000) those are just print out, and then those does not get inserted to failed list. so it will not affect mmio-nonpref/mmio-pref allocation. that will make sure all related bridge io port BAR get disabled for sure. except those print out, do you find any function that does not work? Thanks Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
