On Tue, May 7, 2013 at 2:38 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote: > On Tue, May 7, 2013 at 2:32 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote: >> >> PCI: Delay final fixups until resources are assigned >> >> Commit 4f535093cf "PCI: Put pci_dev in device tree as early as possible" >> moved final fixups from pci_bus_add_device() to pci_device_add(). But >> pci_device_add() happens before resource assignment, so BARs may not be >> valid yet. >> >> Typical flow for hot-add: >> >> pciehp_configure_device >> pci_scan_slot >> pci_scan_single_device >> pci_device_add >> pci_fixup_device(pci_fixup_final, dev) # previous location >> # resource assignment happens here >> pci_bus_add_devices >> pci_bus_add_device >> pci_fixup_device(pci_fixup_final, dev) # new location >> >> [bhelgaas: changelog, move fixups to pci_bus_add_device()] Yes, that is right fix. Thanks Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
