On 04/05/2013 01:52 AM, Michael Ellerman wrote: > Hi Brian, > > > On Thu, Apr 04, 2013 at 04:58:17PM -0500, Brian King wrote: >> >> Add a PCI quirk for VGA devices on Power to set the default VGA device. >> Ensures a default VGA is always set if a graphics adapter is present, >> even if firmware did not initialize it. If more than one graphics >> adapter is present, ensure the one initialized by firmware is set >> as the default VGA device. This ensures that X autoconfiguration >> will work. > > So a few things: > > - You are doing this on all power systems, not just pseries which is I > assume what you're testing on - that seems OK to me, but just > checking. Correct. I've only tested on pseries, but figured it would make sense for this to be more generic. I'm happy to make this pseries specific if that is preferred. > - What is the "initialized by firmware" test? Just that IO & MEM are > enabled? Correct. This is what the x86 code does. Alternatively, its possible there is a chosen attribute in the device tree we could look at. > - You potentially override an existing default, is that a problem? Can > the user set the default? (no AFAICS). I couldn't find anywhere that this could be set by the user and wanted to be able to handle both the case of a single adapter that wasn't initialized by firmware as well as the multi adapter case where only one of the adapters was initialized by firmware. I could have made this smarter so that we only override the default if the previous default was not initialized by firmware, but opted for the simpler patch. > - The x86 code is slightly different, they don't override an existing > default, why do we? I wanted to be able to handle the case of a single graphics adapter installed in a system that has not been initialized by firmware, since I have a system like this. This generally isn't something that x86 would need to do since all graphics adapters should have x86 boot code in them, but very few current graphics adapters have fcode in them today. Thanks, Brian -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
