Hello, [...] > > > > > > - dev_info(dev, "No regulators for downstream device\n"); > > > > > > + dev_info(dev, "Did not get regulators; err=%d\n", ret); > > > > > > > > > > Why is this dev_info() instead of dev_err()? > > > > > > > > I will change this. I can update this directly on the branch if you want. > > > > > > > > > > > + pcie->sr = NULL; > > > > > > > > > > Why can't you set 'pcie->sr' after successfull regulator_bulk_get()? > > > > > > > > Not sure I understand -- it is already set before a successful > > > > regulator_bulk_get() call. > > > > > > Didn't I say 'after'? > > > > Sorry, I misinterpreted your question. I can change it but it would > > just be churn because a new commit is going to refactor this function. > > However, > > I can set pcie->num_regulators "after" in the new commit. > > > > If a new patch is going to change the beahvior, then I'm fine with it for now. > After all, this series is already merged. There is still time if a follow-up patch would be of benefit there. Same goes for Krzysztof
