Bjorn Helgaas wrote:
> I try to make the first word of the subject a verb that says something
> about what the patch does, maybe "Enumerate" in this case?
I usually do that as well, "Enumerate" works for me.
> On Thu, Dec 05, 2024 at 02:23:39PM -0800, Dan Williams wrote:
> > Link encryption is a new PCIe capability defined by "PCIe 6.2 section
> > 6.33 Integrity & Data Encryption (IDE)". While it is a standalone port
>
> Since sec 6.33 doesn't cover the "IDE Extended Capability" (sec
> 7.9.26), I would word this as "a new PCIe feature" here.
Updated to:
"Link encryption is a new PCIe feature enumerated by PCIe 6.2 section
7.9.26 IDE Extended Capability."
> > and endpoint capability, it is also a building block for device security
> > defined by "PCIe 6.2 section 11 TEE Device Interface Security Protocol
> > (TDISP)". That protocol coordinates device security setup between the
> > platform TSM (TEE Security Manager) and device DSM (Device Security
> > Manager). While the platform TSM can allocate resources like stream-ids
> > and manage keys, it still requires system software to manage the IDE
> > capability register block.
>
> s/stream-ids/Stream IDs/ to match spec usage
Got it.
>
> > Add register definitions and basic enumeration for a "selective-stream"
> > IDE capability, a follow on change will select the new CONFIG_PCI_IDE
> > symbol. Note that while the IDE specifications defines both a
> > point-to-point "Link" stream and a root-port-to-endpoint "Selective"
> > stream, only "Selective" is considered for now for platform TSM
> > coordination.
>
> s/root-port/Root Port/ to match spec usage, also below
I also went ahead and updated occurrences of "selective stream" to
"Selective IDE Stream" given that is also how it appears in the spec.
>
> > +void pci_ide_init(struct pci_dev *pdev)
> > +{
> > ...
>
> > + * lets not entertain devices that do not have a
> > + * constant number of address association blocks
>
> s/lets/Let's/
Got it.
