Re: [PATCH] rust: io: rename `io::Io` accessors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 17, 2025 at 10:59:58PM +0100, Miguel Ojeda wrote:
> On Mon, Feb 17, 2025 at 10:37 PM Daniel Almeida
> <daniel.almeida@xxxxxxxxxxxxx> wrote:
> >
> > IMHO, the `writel` and `readl` nomenclature is extremely widespread, so it’s a bit confusing to see this renamed.
> 
> We could generate `#[doc(alias = "...")]`s if that helps -- it would
> appear if you type `writel` in the search, for instance.

This is a good idea, I think.

> 
> (I guess the rename could be justified (just a bit) by the fact that
> in Rust we are using fixed-width integers and so on more...)

This is a good reason too. My main reason for proposing this was that if we back
the trait with both MMIO and PIO `writel` and `readl` nomenclature might falsely
be read as if it is limited to MMIO.




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux