Hi Fiona, > On 17 Feb 2025, at 17:58, Fiona Behrens <me@xxxxxxxxxx> wrote: > > Rename the I/O accessors provided by `Io` to encode the type as > number instead of letter. This is in preparation for Port I/O support > to use a trait for generic accessors. > > Add a `c_fn` argument to the accessor generation macro to translate > between rust and C names. > > Suggested-by: Danilo Krummrich <dakr@xxxxxxxxxx> > Link: https://rust-for-linux.zulipchat.com/#narrow/channel/288089-General/topic/PIO.20support/near/499460541 > Signed-off-by: Fiona Behrens <me@xxxxxxxxxx> IMHO, the `writel` and `readl` nomenclature is extremely widespread, so it’s a bit confusing to see this renamed. On the other hand, I do understand that such a change may be needed for ergonomic reasons when introducing PIO, so I guess we will have to live with it :) Acked-by: Daniel Almeida <daniel.almeida@xxxxxxxxxxxxx>
