On 18/01/2025 02:57, Jon Pan-Doh wrote:
On Thu, Jan 16, 2025 at 6:27 AM Karolina Stolarek
<karolina.stolarek@xxxxxxxxxx> wrote:
I agree that the bus, device and function info is repeated later, but
isn't this line also about the fact we deal with one or multiple errors
in a message? The question is how valuable this information, in itself, is.
I think whether or not there are multiple errors can be gleaned from
__aer_print_error(). It prints out all fields of the status register
(as well as denotes the first error).
That's true, so I think it's reasonable to remove it.
For the code changes:
Reviewed-by: Karolina Stolarek <karolina.stolarek@xxxxxxxxxx>
As for the commit message, I'd drop the before-after dmesg messages and
explain that the information presented by aer_print_port_info() can be
easily inferred from the actual error messages. I had to read the code
to remind myself what information is duplicated.
All the best,
Karolina
Thanks,
Jon
