On Fri, Jul 20, 2012 at 12:17 PM, Jon Mason <jdmason@xxxxxxxx> wrote: > On Tue, Jun 19, 2012 at 6:15 AM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote: >> Hi Jon, >> >> Coverity noticed that pcie_bus_configure_settings() can call >> pcie_bus_configure_set() when "smpss" is uninitialized. >> >> This might be only a theoretical problem because that can only happen >> if pcie_bus_config is PCIE_BUS_PERFORMANCE, and in that case, I >> *think* we don't care about smpss because pcie_write_mps() ignores the >> mps passed in and always uses dev->pcie_mpss. But it takes a lot of >> analysis to be certain, and it would be better to make >> pcie_bus_configure_settings() cleaner. >> >> Would you mind fixing this up? > > Sorry, just saw this. Do you still want me to take a whack at it? It'd be great if you did. I haven't done anything with it, but would like to resolve Coverity warnings. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
