pcie_bus_configure_settings() use of uninitialized value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jon,

Coverity noticed that pcie_bus_configure_settings() can call
pcie_bus_configure_set() when "smpss" is uninitialized.

This might be only a theoretical problem because that can only happen
if pcie_bus_config is PCIE_BUS_PERFORMANCE, and in that case, I
*think* we don't care about smpss because pcie_write_mps() ignores the
mps passed in and always uses dev->pcie_mpss.  But it takes a lot of
analysis to be certain, and it would be better to make
pcie_bus_configure_settings() cleaner.

Would you mind fixing this up?

Thanks,
  Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux