> +static void __pci_ide_stream_setup(struct pci_dev *pdev, struct pci_ide *ide)
> +{
> + int pos;
> + u32 val;
> +
> + pos = sel_ide_offset(pdev->sel_ide_cap, ide->stream_id,
> + pdev->nr_ide_mem);
> +
> + val = FIELD_PREP(PCI_IDE_SEL_RID_1_LIMIT_MASK, ide->devid_end);
> + pci_write_config_dword(pdev, pos + PCI_IDE_SEL_RID_1, val);
> +
> + val = FIELD_PREP(PCI_IDE_SEL_RID_2_VALID, 1) |
> + FIELD_PREP(PCI_IDE_SEL_RID_2_BASE_MASK, ide->devid_start) |
> + FIELD_PREP(PCI_IDE_SEL_RID_2_SEG_MASK, ide->domain);
> + pci_write_config_dword(pdev, pos + PCI_IDE_SEL_RID_2, val);
> +
> + for (int i = 0; i < ide->nr_mem; i++) {
> + val = FIELD_PREP(PCI_IDE_SEL_ADDR_1_VALID, 1) |
> + FIELD_PREP(PCI_IDE_SEL_ADDR_1_BASE_LOW_MASK,
> + lower_32_bits(ide->mem[i].start) >>
> + PCI_IDE_SEL_ADDR_1_BASE_LOW_SHIFT) |
> + FIELD_PREP(PCI_IDE_SEL_ADDR_1_LIMIT_LOW_MASK,
> + lower_32_bits(ide->mem[i].end) >>
> + PCI_IDE_SEL_ADDR_1_LIMIT_LOW_SHIFT);
Oh, I missunderstood the _LOW_SHIFT Macros. But still think if they
could be moved out of pci_reg.h. Placing in pci_reg.h makes me think
they are some register field offsets.
Thanks,
Yilun
