On Mon, Nov 18, 2024 at 02:59:59AM +0000, Hongxing Zhu wrote: > > -----Original Message----- > > From: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > > Sent: 2024年11月15日 14:52 > > To: Hongxing Zhu <hongxing.zhu@xxxxxxx> > > Cc: l.stach@xxxxxxxxxxxxxx; bhelgaas@xxxxxxxxxx; lpieralisi@xxxxxxxxxx; > > kw@xxxxxxxxx; robh@xxxxxxxxxx; krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; > > shawnguo@xxxxxxxxxx; Frank Li <frank.li@xxxxxxx>; > > s.hauer@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; imx@xxxxxxxxxxxxxxx; > > kernel@xxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; > > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > > linux-kernel@xxxxxxxxxxxxxxx > > Subject: Re: [PATCH v6 05/10] PCI: imx6: Make core reset assertion > > deassertion symmetric > > > > On Fri, Nov 01, 2024 at 03:06:05PM +0800, Richard Zhu wrote: > > > Add apps_reset deassertion in the imx_pcie_deassert_core_reset(). Let > > > it be symmetric with imx_pcie_assert_core_reset(). > > > > > > In the commit first introduced apps_reset, apps_reset is asserted in > > > imx6_pcie_assert_core_reset(), but it is de-asserted in another place, > > > in > > > > I'd suggest rewording like below to make it easy to understand, > > > > "PCI: imx6: Deassert apps_reset in imx_pcie_assert_core_reset() > I'm very appreciate for your rewords. Should the imx_pcie_assert_core_reset() > be imx_pcie_deassert_core_reset()? > Yeah! - Mani -- மணிவண்ணன் சதாசிவம்
