On Fri, Nov 15, 2024 at 12:38:33PM -0500, Frank Li wrote: > On Fri, Nov 15, 2024 at 12:39:32PM +0530, Manivannan Sadhasivam wrote: > > On Fri, Nov 01, 2024 at 03:06:08PM +0800, Richard Zhu wrote: > > > From: Frank Li <Frank.Li@xxxxxxx> > > > > > > Call common dwc suspend/resume function. Use dwc common iATU method to > > > send out PME_TURN_OFF message. In Old DWC implementations, > > > PCIE_ATU_INHIBIT_PAYLOAD bit in iATU Ctrl2 register is reserved. So the > > > generic DWC implementation of sending the PME_Turn_Off message using a > > > dummy MMIO write cannot be used. Use previouse method to kick off > > > PME_TURN_OFF MSG for these platforms. > > > > > > Replace the imx_pcie_stop_link() and imx_pcie_host_exit() by > > > dw_pcie_suspend_noirq() in imx_pcie_suspend_noirq(). > > > > > > Since dw_pcie_suspend_noirq() already does these, see below call stack: > > > dw_pcie_suspend_noirq() > > > dw_pcie_stop_link(); > > > imx_pcie_stop_link(); > > > pci->pp.ops->deinit(); > > > imx_pcie_host_exit(); > > > > > > Replace the imx_pcie_host_init(), dw_pcie_setup_rc() and > > > imx_pcie_start_link() by dw_pcie_resume_noirq() in > > > imx_pcie_resume_noirq(). > > > > > > Since dw_pcie_resume_noirq() already does these, see below call stack: > > > dw_pcie_resume_noirq() > > > pci->pp.ops->init(); > > > imx_pcie_host_init(); > > > dw_pcie_setup_rc(); > > > dw_pcie_start_link(); > > > imx_pcie_start_link(); > > > > > > > Are these two changes (dw_pcie_suspend_noirq(), dw_pcie_resume_noirq()) related > > to this patch? If not, these should be in a separate patch. > > > Sorry, this patch have not touch dw_pcie_suspend_noirq() and > dw_pcie_resume_noirq()'s implement, just call it. I have not understood > what's your means. > Sorry, I got confused. Please ignore above comment. - Mani -- மணிவண்ணன் சதாசிவம்
