On 24-11-22 03:28:24, Krzysztof Wilczyński wrote: > Hello, > > [...] > > > - pci_err(dev, "failed to add device link between %s and %s\n", > > > - dev_name(&dev->dev), pdev->name); > > > + pci_err(dev, "failed to add device link to power control device %s\n", > > > > Maybe use 'pwrctrl' instead of 'power control'? > > Changed, thank you! This makes the verbiage consistent with other > messages, code comments, etc. ... this one might have slip into the after merge window. Also, Bjorn and I, we had a conversation about the correct wording here in user-facing messages. The "power control" vs "pwrctrl", etc. There is a single existing precedent within the code base for the "pwrctrl" use per: 55: ret = devm_pci_pwrctrl_device_set_ready(dev, &data->ctx); 56- if (ret) 57- return dev_err_probe(dev, ret, 58: "Failed to register the pwrctrl wrapper\n"); So, we should be consistent within the documentation and anything user-facing around what wording we use, I believe. Whichever it will be in the end. Krzysztof
