On Tue, Nov 12, 2024 at 04:47:48PM +0100, Lukas Wunner wrote: > On Fri, Oct 18, 2024 at 05:47:53PM +0300, Ilpo Järvinen wrote: > > +EXPORT_SYMBOL_GPL(pcie_set_target_speed); > > My apologies for another belated comment on this series. > This patch is now a688ab21eb72 on pci/bwctrl: > > I note that pcie_set_target_speed() is not called my a modular user > (CONFIG_PCIE_THERMAL is bool, not tristate), so the above-quoted export > isn't really necessary right now. I don't know if it was added > intentionally because some modular user is expected to show up > in the near future. Dropped the export for now, we can add it back if/when needed. Bjorn