Re: [PATCH v3 05/12] PCI: of_property: Assign PCI instead of CPU bus address to dynamic bridge nodes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v3 05/12] PCI: of_property: Assign PCI instead of CPU bus address to dynamic bridge nodes
From: Herve Codina <herve.codina@xxxxxxxxxxx>
Date: Mon, 4 Nov 2024 09:06:23 +0100
Cc: Michael Turquette <mturquette@xxxxxxxxxxxx>, Stephen Boyd <sboyd@xxxxxxxxxx>, Rob Herring <robh@xxxxxxxxxx>, Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>, Conor Dooley <conor+dt@xxxxxxxxxx>, Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>, Broadcom internal kernel review list <bcm-kernel-feedback-list@xxxxxxxxxxxx>, Lorenzo Pieralisi <lpieralisi@xxxxxxxxxx>, Krzysztof Wilczynski <kw@xxxxxxxxx>, Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Linus Walleij <linus.walleij@xxxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Bartosz Golaszewski <brgl@xxxxxxxx>, Derek Kiernan <derek.kiernan@xxxxxxx>, Dragan Cvetic <dragan.cvetic@xxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Saravana Kannan <saravanak@xxxxxxxxxx>, linux-clk@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, linux-rpi-kernel@xxxxxxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx, linux-gpio@xxxxxxxxxxxxxxx, Masahiro Yamada <masahiroy@xxxxxxxxxx>, Stefan Wahren <wahrenst@xxxxxxx>, Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx>, Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxx>, Andrew Lunn <andrew@xxxxxxx>
In-reply-to: <f6b445b764312fd8ab96745fe4e97fb22f91ae4c.1730123575.git.andrea.porta@suse.com>
Organization: Bootlin
References: <cover.1730123575.git.andrea.porta@suse.com> <f6b445b764312fd8ab96745fe4e97fb22f91ae4c.1730123575.git.andrea.porta@suse.com>

Hi Andrea,

On Mon, 28 Oct 2024 15:07:22 +0100
Andrea della Porta <andrea.porta@xxxxxxxx> wrote:

> When populating "ranges" property for a PCI bridge, of_pci_prop_ranges()
> incorrectly use the CPU bus address of the resource. Since this is a PCI-PCI
> bridge, the window should instead be in PCI address space. Call
> pci_bus_address() on the resource in order to obtain the PCI bus
> address.
> 
> Signed-off-by: Andrea della Porta <andrea.porta@xxxxxxxx>

Tested ok with my LAN966x PCI device.

Tested-by: Herve Codina <herve.codina@xxxxxxxxxxx>

Best regards,
Hervé

Follow-Ups:
- Re: [PATCH v3 05/12] PCI: of_property: Assign PCI instead of CPU bus address to dynamic bridge nodes
  - From: Andrea della Porta

References:
- [PATCH v3 00/12] Add support for RaspberryPi RP1 PCI device using a DT overlay
  - From: Andrea della Porta
- [PATCH v3 05/12] PCI: of_property: Assign PCI instead of CPU bus address to dynamic bridge nodes
  - From: Andrea della Porta

Prev by Date: [PATCH v2] PCI: j721e: Deassert PERST# after a delay of PCIE_T_PVPERL_MS ms
Next by Date: Re: [PATCH v3 06/12] of: address: Preserve the flags portion on 1:1 dma-ranges mapping
Previous by thread: Re: [PATCH v3 05/12] PCI: of_property: Assign PCI instead of CPU bus address to dynamic bridge nodes
Next by thread: Re: [PATCH v3 05/12] PCI: of_property: Assign PCI instead of CPU bus address to dynamic bridge nodes
Index(es):
- Date
- Thread

[Index of Archives] [DMA Engine] [Linux Coverity] [Linux USB] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI] [Greybus]