> > +maintainers:
> > + - Wei Fang <wei.fang@xxxxxxx>
> > + - Clark Wang <xiaoning.wang@xxxxxxx>
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - nxp,imx95-netc-blk-ctrl
> > +
> > + reg:
> > + minItems: 2
> > + maxItems: 3
>
> You have one device, why this is flexible? Device either has exactly 2
> or exactly 3 IO spaces, not both depending on the context.
>
There are three register blocks, IERB and PRB are inside NETC IP, but NETCMIX
is outside NETC. There are dependencies between these three blocks, so it is
better to configure them in one driver. But for other platforms like S32, it does
not have NETCMIX, so NETCMIX is optional.
> > +
> > + reg-names:
> > + minItems: 2
> > + items:
> > + - const: ierb
> > + - const: prb
> > + - const: netcmix
> > +
> > + "#address-cells":
> > + const: 2
> > +
> > + "#size-cells":
> > + const: 2
> > +
> > + ranges: true
> > + assigned-clocks: true
> > + assigned-clock-parents: true
> > + assigned-clock-rates: true
>
> Drop these three.
>
Okay, I will drop them. Thanks.
> > +
> > + clocks:
> > + maxItems: 1
> > +
> > + clock-names:
> > + const: ipg
> > +
> > + power-domains:
> > + maxItems: 1
> > +
> > +patternProperties:
> > + "^pcie@[0-9a-f]+$":
> > + $ref: /schemas/pci/host-generic-pci.yaml#
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - reg-names
> > + - "#address-cells"
> > + - "#size-cells"
> > + - ranges
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + bus {
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > +
> > + netc-blk-ctrl@4cde0000 {
>
> system-controller? Don't use compatible as node name.
>
netc-blk-ctrl provides pre-configuration and warm reset services for the entire NETC
IP, so system-controller sounds good.
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdevicetr
> ee-specification.readthedocs.io%2Fen%2Flatest%2Fchapter2-devicetree-basics.
> html%23generic-names-recommendation&data=05%7C02%7Cwei.fang%40nx
> p.com%7C35715ef05b824c5d479f08dcf32fd256%7C686ea1d3bc2b4c6fa92cd
> 99c5c301635%7C0%7C0%7C638652633944352532%7CUnknown%7CTWFpb
> GZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6
> Mn0%3D%7C0%7C%7C%7C&sdata=unWcE1OaH2Id%2FEny9UFAUH%2F5Xablg
> PM0Yj4Br2jfQuI%3D&reserved=0
>
> Best regards,
> Krzysztof
