On 10/17/24 09:37, Damien Le Moal wrote: > On 10/17/24 01:59, Manivannan Sadhasivam wrote: >> On Tue, Oct 15, 2024 at 06:07:12PM +0900, Damien Le Moal wrote: >>> The PCI endpoint controller operation interface for the align_addr() >>> operation uses the phys_addr_t type for the PCI address argument and >>> return a value using this type. This is not ideal as PCI addresses are >>> bus addresses, not regular memory physical addresses. Replace the use of >>> phys_addr_t for this operation with the generic u64 type. To be >>> consistent with this change the Designware driver implementation of this >>> operation (function dw_pcie_ep_align_addr()) as well as the type of PCI >>> address fields of struct pci_epc_map are also changed. >>> >>> Fixes: e98c99e2ccad ("PCI: endpoint: Introduce pci_epc_mem_map()/unmap()") >>> Fixes: cb6b7158fdf5 ("PCI: dwc: endpoint: Implement the pci_epc_ops::align_addr() operation") >>> Signed-off-by: Damien Le Moal <dlemoal@xxxxxxxxxx> >> >> I thought of applying it, but then decided to squash it with the offending >> patches. > > Fine with me. Thanks ! Just checked the pci/endpoint branch but I do not see this patch squashed there. Did you push the change ? -- Damien Le Moal Western Digital Research