On 10/11/24 05:19, Damien Le Moal wrote: nit:- please consider following subject line as nvmef_create_ctrl() doesn't exists :- nvme-fabrics: export nvmf_create_ctrl() > Export nvmef_create_ctrl() to allow drivers to directly call this > function instead of forcing the creation of a fabrics host controller > with a write to /dev/nvmef. The export is restricted to the NVME_FABRICS I'm not sure /dev/nvmef exists I think you meant /dev/nvme-fabrics above ? > namespace. > > Signed-off-by: Damien Le Moal <dlemoal@xxxxxxxxxx> With above fix, looks good. Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx> -ck
