On 10/11/24 05:19, Damien Le Moal wrote: > The code for nvmet_get_log_page_len() has no pedendency on nvme target > code and only depends on struct nvme_command. Move this helper function > out of drivers/nvme/target/admin-cmd.c and inline it as part of the > generic definitions in include/linux/nvme.h. Apply the same modification > to nvmet_get_log_page_offset(). > > Signed-off-by: Damien Le Moal<dlemoal@xxxxxxxxxx> > Reviewed-by: Christoph Hellwig<hch@xxxxxx> Looks good. Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx> -ck
