On 9/6/24 11:20, Jim Quinlan wrote:
On Fri, Sep 6, 2024 at 7:10 AM Muhammad Usama Anjum
<usama.anjum@xxxxxxxxxxxxx> wrote:
brcm_pcie_get_inbound_wins() can return negative error. As
num_inbound_wins is unsigned, we'll be unable to recognize the error.
Hence store return value of brcm_pcie_get_inbound_wins() in ret which is
signed and store result back to num_inbound_wins after confirming that
it isn't negative.
Hello Muhammad,
You are correct -- I was asked to make a few variables to be of the
type u8, but I missed having an int (ret) hold the
resultof that call. I believe I am still in the process of submitting
this commit series -- V7 is coming next -- so I will
take your email as a review instead of adding a fixup commit.
Unless Bjorn says that V6 was applied.
A similar patch has already been submitted to address this in a slightly
different way:
https://lore.kernel.org/all/20240904161953.46790-2-riyandhiman14@xxxxxxxxx/
--
Florian
