>>> This patch introduces a PCI hotplug controller driver for the OCTEON
>>> PCIe device, a multi-function PCIe device where the first function acts
>>> as a hotplug controller. It is equipped with MSI-x interrupts to notify
>>> the host of hotplug events from the OCTEON firmware.
>>>
>>> The driver facilitates the hotplugging of non-controller functions
>>> within the same device. During probe, non-controller functions are
>>> removed and registered as PCI hotplug slots. The slots are added back
>>> only upon request from the device firmware. The driver also allows the
>>> enabling and disabling of the slots via sysfs slot entries, provided by
>>> the PCI hotplug framework.
>>>
>>> Signed-off-by: Shijith Thotton <sthotton@xxxxxxxxxxx>
>>> Signed-off-by: Vamsi Attunuru <vattunuru@xxxxxxxxxxx>
>>I was curious, so drive by review.
>>
>>What was Vamsi's involvement? Given Shijith sent this
>>I'd guess co developer? In which Co-developed-by tag
>>should be used.
>>
...
>>> +}
>>> +
>>> +static int octep_hp_controller_setup(struct pci_dev *pdev, struct
>>octep_hp_controller *hp_ctrl)
>>> +{
>>> + struct device *dev = &pdev->dev;
>>> + int ret;
>>> +
>>> + ret = pcim_enable_device(pdev);
>>> + if (ret) {
>>> + dev_err(dev, "Failed to enable PCI device\n");
>>Only called from probe, so
>> return dev_err_probe()
>>
>>> + return ret;
>>> + }
>>> +
>>> + ret = pcim_iomap_regions(pdev, BIT(0), OCTEP_HP_DRV_NAME);
>>Given there is a patch on list deprecating this, reconsider.
>> https://lore.kernel.org/all/20240807083018.8734-2-
>pstanner@xxxxxxxxxx/
>>+CC Philipp
>>
>
>Okay. The API is available in origin/devres branch. Will rebase on top of it.
>
I forgot about the kernel test robot.
I'll hold off on making this change until the patch is merged into pci/next.
