Hi Shijith, kernel test robot noticed the following build errors: [auto build test ERROR on pci/next] [also build test ERROR on pci/for-linus linus/master v6.11-rc4 next-20240821] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Shijith-Thotton/PCI-hotplug-Add-OCTEON-PCI-hotplug-controller-driver/20240820-233005 base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next patch link: https://lore.kernel.org/r/20240820152734.642533-1-sthotton%40marvell.com patch subject: [PATCH] PCI: hotplug: Add OCTEON PCI hotplug controller driver config: mips-allyesconfig (https://download.01.org/0day-ci/archive/20240821/202408212127.ed49pQkJ-lkp@xxxxxxxxx/config) compiler: mips-linux-gcc (GCC) 14.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240821/202408212127.ed49pQkJ-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202408212127.ed49pQkJ-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): drivers/pci/hotplug/octep_hp.c: In function 'octep_hp_intr_handler': >> drivers/pci/hotplug/octep_hp.c:190:21: error: implicit declaration of function 'readq'; did you mean 'readl'? [-Wimplicit-function-declaration] 190 | slot_mask = readq(hp_ctrl->base + OCTEP_HP_INTR_OFFSET(vec_type)); | ^~~~~ | readl >> drivers/pci/hotplug/octep_hp.c:210:9: error: implicit declaration of function 'writeq'; did you mean 'writel'? [-Wimplicit-function-declaration] 210 | writeq(slot_mask, hp_ctrl->base + OCTEP_HP_INTR_OFFSET(vec_type)); | ^~~~~~ | writel vim +190 drivers/pci/hotplug/octep_hp.c 178 179 static irqreturn_t octep_hp_intr_handler(int irq, void *data) 180 { 181 struct octep_hp_controller *hp_ctrl = data; 182 struct pci_dev *pdev = hp_ctrl->pdev; 183 enum octep_hp_vec_type vec_type; 184 struct octep_hp_cmd *hp_cmd; 185 u64 slot_mask; 186 187 vec_type = pci_irq_vector(pdev, OCTEP_HP_INTR_VECTOR(OCTEP_HP_VEC_ENA)) == irq ? 188 OCTEP_HP_VEC_ENA : OCTEP_HP_VEC_DIS; 189 > 190 slot_mask = readq(hp_ctrl->base + OCTEP_HP_INTR_OFFSET(vec_type)); 191 if (!slot_mask) { 192 dev_err(&pdev->dev, "Invalid slot mask %llx\n", slot_mask); 193 return IRQ_HANDLED; 194 } 195 196 hp_cmd = kzalloc(sizeof(*hp_cmd), GFP_ATOMIC); 197 if (!hp_cmd) 198 return IRQ_HANDLED; 199 200 hp_cmd->slot_mask = slot_mask; 201 hp_cmd->vec_type = vec_type; 202 203 /* Add the command to the list and schedule the work */ 204 spin_lock(&hp_ctrl->hp_cmd_lock); 205 list_add_tail(&hp_cmd->list, &hp_ctrl->hp_cmd_list); 206 spin_unlock(&hp_ctrl->hp_cmd_lock); 207 schedule_work(&hp_ctrl->work); 208 209 /* Clear the interrupt */ > 210 writeq(slot_mask, hp_ctrl->base + OCTEP_HP_INTR_OFFSET(vec_type)); 211 212 return IRQ_HANDLED; 213 } 214 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
