On 7/11/24 01:16, Jim Quinlan wrote:
> The 7712 SOC adds a software init reset device for the PCIe HW.
> If found in the DT node, use it.
>
> Signed-off-by: Jim Quinlan <james.quinlan@xxxxxxxxxxxx>
> ---
> drivers/pci/controller/pcie-brcmstb.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c
> index 92816d8d215a..4dc2ff7f3167 100644
> --- a/drivers/pci/controller/pcie-brcmstb.c
> +++ b/drivers/pci/controller/pcie-brcmstb.c
> @@ -266,6 +266,7 @@ struct brcm_pcie {
> struct reset_control *rescal;
> struct reset_control *perst_reset;
> struct reset_control *bridge;
> + struct reset_control *swinit;
> int num_memc;
> u64 memc_size[PCIE_BRCM_MAX_MEMC];
> u32 hw_rev;
> @@ -1633,12 +1634,27 @@ static int brcm_pcie_probe(struct platform_device *pdev)
> if (IS_ERR(pcie->bridge))
> return PTR_ERR(pcie->bridge);
>
> + pcie->swinit = devm_reset_control_get_optional_exclusive(&pdev->dev, "swinit");
> + if (IS_ERR(pcie->swinit))
> + return PTR_ERR(pcie->swinit);
> +
> ret = clk_prepare_enable(pcie->clk);
> if (ret) {
> dev_err(&pdev->dev, "could not enable clock\n");
> return ret;
> }
>
> + ret = reset_control_assert(pcie->swinit);
> + if (ret) {
> + dev_err_probe(&pdev->dev, ret, "could not assert reset 'swinit'\n");
> + goto clk_out;
> + }
If there is a new version, please add blank line here.
Otherwise:
Reviewed-by: Stanimir Varbanov <svarbanov@xxxxxxx>
~Stan
> + ret = reset_control_deassert(pcie->swinit);
> + if (ret) {
> + dev_err(&pdev->dev, "could not de-assert reset 'swinit' after asserting\n");
> + goto clk_out;
> + }
> +
> ret = reset_control_reset(pcie->rescal);
> if (ret) {
> dev_err(&pdev->dev, "failed to deassert 'rescal'\n");
