On Thu, Jul 4, 2024 at 7:40 AM Markus Elfring <Markus.Elfring@xxxxxx> wrote:
> [-- Attachment #1: Type: text/plain, Size: 1685 bytes --]
Can improved adjustments be provided as regular diff data
(without an extra attachment)?
I'm not sure what you are referring to... I see no attachment in the copy of this email I received, and I am sending my patches with "git send-email".
I will address your other comments in v3.
Regards,
Jim Quinlan
Broadcom STB/CM
> Instead of invoking "clk_disable_unprepare(pcie->clk)" in
> a number of error paths, we can just use a "clk_out" label
> and goto the label after setting the return value.
* Please improve such a change description with imperative wordings.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc6#n94
* How do you think about to use a summary phrase like
“Use more common error handling code in brcm_pcie_probe()”?
…
> +++ b/drivers/pci/controller/pcie-brcmstb.c
…
> ret = reset_control_reset(pcie->rescal);
> - if (ret)
> + if (ret) {
> dev_err(&pdev->dev, "failed to deassert 'rescal'\n");
> + goto clk_out;
> + }
>
> ret = brcm_phy_start(pcie);
…
Does this software update complete the exception handling?
Would you like to add any tags (like “Fixes” and “Cc”) accordingly?
…
> @@ -1676,6 +1677,9 @@ static int brcm_pcie_probe(struct platform_device *pdev)
>
> return 0;
>
> +clk_out:
> + clk_disable_unprepare(pcie->clk);
> + return ret;
> fail:
…
I suggest to add a blank line before the second label.
Regards,
Markus
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
