Hi Jim, On 7/3/24 21:02, Jim Quinlan wrote: > In some cases the result of a reset_control_xxx() call have been ignored. > Now we check all return values of such functions and at the least issue a > dev_err(...) message if the return value is not zero. > When I made the comment for the return value of reset_control_xxx API I was thinking for propagating the error to upper PCI layer and not just print it. Printing the error is a step forward but I don't think it is enough. Please drop the patch from the series, we can fix that problem in the driver with follow up patches. ~Stan > Signed-off-by: Jim Quinlan <james.quinlan@xxxxxxxxxxxx> > --- > drivers/pci/controller/pcie-brcmstb.c | 33 ++++++++++++++++++++------- > 1 file changed, 25 insertions(+), 8 deletions(-) >
