On Tue, May 14, 2024 at 11:30:05AM -0700, matthew.gerlach@xxxxxxxxxxxxxxx wrote: > > > On Tue, 14 May 2024, Rob Herring wrote: > > > > > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > > > yamllint warnings/errors: > > > > > > dtschema/dtc warnings/errors: > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/altr,pcie-root-port.example.dtb: pcie@c00000000: interrupt-map: [[0, 0, 0, 1, 2, 1, 0, 0, 0], [2, 2, 2, 0, 0, 0, 3, 2, 3], [0, 0, 0, 4, 2, 4]] is too short > > > from schema $id: http://devicetree.org/schemas/altr,pcie-root-port.yaml# > > > > You need 3 address cells after the phandles since the interrupt parent > > has 3 address cells. > > Thanks for the extra explanation. Adding 3 address cells of 0 made the > warning go away. > > > > > What does your actual DT contain and do interrupts work because > > interrupts never would have worked I think? Making the PCI host the > > interrupt parent didn't even work in the kernel until somewhat recently > > (maybe a few years now). That's why a bunch of PCI hosts have an > > interrupt-controller child node. > > The following DT snippet comes from > https://www.rocketboards.org/foswiki/Projects/Stratix10PCIeRootPortWithMSI > > The Linux kernel version is 4.14.130-ltsi. Would the use of the msi-parent > node make everything work? Possibly? I would think MSIs are preferred and almost anything should support MSIs now. Rob
