On Mon, May 13, 2024 at 05:12:42PM -0500, Rob Herring (Arm) wrote: > > On Mon, 13 May 2024 15:59:13 -0500, matthew.gerlach@xxxxxxxxxxxxxxx wrote: > > From: Matthew Gerlach <matthew.gerlach@xxxxxxxxxxxxxxx> > > > > Convert the device tree bindings for the Altera Root Port PCIe controller > > from text to YAML. > > > > Signed-off-by: Matthew Gerlach <matthew.gerlach@xxxxxxxxxxxxxxx> > > --- > > v5: > > - add interrupt-conntroller #interrupt-cells to required field > > - don't touch original example dts > > > > v4: > > - reorder reg-names to match original binding > > - move reg and reg-names to top level with limits. > > > > v3: > > - Added years to copyright > > - Correct order in file of allOf and unevaluatedProperties > > - remove items: in compatible field > > - fix reg and reg-names constraints > > - replace deprecated pci-bus.yaml with pci-host-bridge.yaml > > - fix entries in ranges property > > - remove device_type from required > > > > v2: > > - Move allOf: to bottom of file, just like example-schema is showing > > - add constraint for reg and reg-names > > - remove unneeded device_type > > - drop #address-cells and #size-cells > > - change minItems to maxItems for interrupts: > > - change msi-parent to just "msi-parent: true" > > - cleaned up required: > > - make subject consistent with other commits coverting to YAML > > - s/overt/onvert/g > > --- > > .../devicetree/bindings/pci/altera-pcie.txt | 50 ---------- > > .../bindings/pci/altr,pcie-root-port.yaml | 93 +++++++++++++++++++ > > 2 files changed, 93 insertions(+), 50 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/pci/altera-pcie.txt > > create mode 100644 Documentation/devicetree/bindings/pci/altr,pcie-root-port.yaml > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/altr,pcie-root-port.example.dtb: pcie@c00000000: interrupt-map: [[0, 0, 0, 1, 2, 1, 0, 0, 0], [2, 2, 2, 0, 0, 0, 3, 2, 3], [0, 0, 0, 4, 2, 4]] is too short > from schema $id: http://devicetree.org/schemas/altr,pcie-root-port.yaml# You need 3 address cells after the phandles since the interrupt parent has 3 address cells. What does your actual DT contain and do interrupts work because interrupts never would have worked I think? Making the PCI host the interrupt parent didn't even work in the kernel until somewhat recently (maybe a few years now). That's why a bunch of PCI hosts have an interrupt-controller child node. Rob
