On Tue, Apr 30 2024 at 10:37, Herve Codina wrote:
> /**
> * irq_domain_xlate_onecell() - Generic xlate for direct one cell bindings
> + * @d: IRQ domain involved in the translation
Please write out 'Interrupt domain'
> + * @ctrlr: the DT node for the device whose interrupt we're translating
Device tree node. And we are not translating anything.
> + * @intspec: the interrupt specifier data from the DT
> + * @intsize: the number of entries in @intspec
> + * @out_hwirq: pointer at which to write the hwirq number
Pointer to starage for the hardware interrupt number
> + * @out_type: pointer at which to write the interrupt type
...
Please align these in tabular fashion:
+ * @d: Interrupt domain involved in the translation
+ * @ctrlr: The device tree node for the device whose interrupt is translated
+ * @intspec: The interrupt specifier data from the device tree
+ * @intsize: The number of entries in @intspec
+ * @out_hwirq: Pointer to storage for the hardware interrupt number
+ * @out_type: Pointer to storage for the interrupt type
> /**
> * irq_domain_translate_onecell() - Generic translate for direct one cell
> * bindings
> + * @d: IRQ domain involved in the translation
> + * @fwspec: FW interrupt specifier to translate
Firmware interrupt specifier
Thanks,
tglx
