Dave Jiang wrote: > Move PCI_DVSEC_VENDOR_ID_CXL in CXL private code to PCI_VENDOR_ID_CXL in > pci_ids.h in order to be utilized in PCI subsystem. > > The response Bjorn received from the PCI SIG was "1E98h is not a VID in our > system, but 1E98 has already been reserved by CXL." He suggested "we should > add '#define PCI_VENDOR_ID_CXL 0x1e98' so that if we ever *do* see such an > assignment, we'll be more likely to flag it as an issue. Perhaps indent these as quotes, the second quote is missing a trailing double-quote. ...but maybe even better to justify this change rather than the reaction to the change. Something like: -- When uplevelling PCI_DVSEC_VENDOR_ID_CXL to a common location Bjorn suggested making it a proper PCI_VENDOR_ID_* define in include/linux/pci_ids.h. While it is not in the PCI IDs database it is a reserved value and Linux treats it as a 'vendor id' for all intents and purposes [1]. --- ...where that footnote can link back to the conversation for the background. Other than that, you can add: Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx>
