RE: [PATCH v3 3/3] Add function to display cxl1.1 device link status

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dan Williams wrote:
> Kobayashi,Daisuke wrote:
> > From: KobayashiDaisuke <kobayashi.da-06@xxxxxxxxxxx>
> >
> > This patch adds a function to output the link status of the CXL1.1
> > device when it is connected.
> >
> > In CXL1.1, the link status of the device is included in the RCRB
> > mapped to the memory mapped register area. The value of that register
> > is outputted to sysfs, and based on that, displays the link status information.
> >
> > Signed-off-by: "KobayashiDaisuke" <kobayashi.da-06@xxxxxxxxxxx>
> > ---
> >  lib/access.c | 29 +++++++++++++++++++++
> >  lib/pci.h    |  2 ++
> >  ls-caps.c    | 73
> ++++++++++++++++++++++++++++++++++++++++++++++++
> ++++
> >  3 files changed, 104 insertions(+)
> 
> Including a userspace patch in a kernel patch submission breaks kernel patch
> management tools like b4 shazam:
> 
> ---
> $ b4 shazam 20240312080559.14904-1-kobayashi.da-06@xxxxxxxxxxx
> Grabbing thread from
> lore.kernel.org/all/20240312080559.14904-1-kobayashi.da-06@xxxxxxxxxxx/t.
> mbox.gz
> Checking for newer revisions
> Grabbing search results from lore.kernel.org Analyzing 8 messages in the
> thread Checking attestation on all messages, may take a moment...
> ---
>   ✓ [PATCH v3 1/3] Add sysfs attribute for CXL 1.1 device link status
>   ✓ [PATCH v3 2/3] Remove conditional branch that is not suitable for cxl1.1
> devices
>   ✓ [PATCH v3 3/3] Add function to display cxl1.1 device link status
>   ---
>   ✓ Signed: DKIM/fujitsu.com
> ---
> Total patches: 3
> ---
> Applying: Add sysfs attribute for CXL 1.1 device link status
> Applying: Remove conditional branch that is not suitable for cxl1.1 devices
> Applying: Add function to display cxl1.1 device link status Patch failed at 0003
> Add function to display cxl1.1 device link status When you have resolved this
> problem, run "git am --continue".
> If you prefer to skip this patch, run "git am --skip" instead.
> To restore the original branch and stop patching, run "git am --abort".
> /home/dwillia2/git/linux/.git/rebase-apply/patch:117: trailing whitespace.
>     w = (u16)strtoul(buf, NULL, 16);
> /home/dwillia2/git/linux/.git/rebase-apply/patch:130: trailing whitespace.
>     w = (u16)strtoul(buf, NULL, 16);
> /home/dwillia2/git/linux/.git/rebase-apply/patch:158: trailing whitespace.
> 
> error: lib/access.c: does not exist in index
> error: lib/pci.h: does not exist in index
> error: ls-caps.c: does not exist in index
> hint: Use 'git am --show-current-patch=diff' to see the failed patch
> ---
> 
> ...and this patch should wait until the kernel change is accepted before being
> submitted directly to the PCI utils project which does not watch this linux-cxl
> mailing list.

Thank you! I will submit the patch for pciutils separately.




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux