On Wed, Mar 06, 2024 at 10:56:49AM +0100, Johan Hovold wrote: > Commit 9f4f3dfad8cf ("PCI: qcom: Enable ASPM for platforms supporting > 1.9.0 ops") started enabling ASPM unconditionally when the hardware > claims to support it. This triggers Correctable Errors for some PCIe > devices on machines like the Lenovo ThinkPad X13s when L0s is enabled, > which could indicate an incomplete driver ASPM implementation or that > the hardware does in fact not support L0s. > > This has now been confirmed by Qualcomm to be the case for sc8280xp and > its derivate platforms (e.g. sa8540p and sa8295p). Specifically, the PHY > configuration used on these platforms is not correctly tuned for L0s and > there is currently no updated configuration available. > > Add a new flag to the driver configuration data and use it to disable > ASPM L0s on sc8280xp, sa8540p and sa8295p for now. > > Note that only the 1.9.0 ops enable ASPM currently. > > Fixes: 9f4f3dfad8cf ("PCI: qcom: Enable ASPM for platforms supporting 1.9.0 ops") > Cc: stable@xxxxxxxxxxxxxxx # 6.7 > Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx> Reviewed-by: Bjorn Andersson <andersson@xxxxxxxxxx> Regards, Bjorn