On Fri, Feb 02, 2024 at 07:53:24PM +0100, Lorenzo Pieralisi wrote: > On Fri, Feb 02, 2024 at 08:25:58AM -0500, Frank Li wrote: > > On Fri, Feb 02, 2024 at 01:12:41PM +0100, Lorenzo Pieralisi wrote: > > > "PCI: imx6: Use "linux,pci-domain" as slot ID" > > > > > > On Fri, Jan 19, 2024 at 12:11:11PM -0500, Frank Li wrote: > > > > Avoid use get slot id by compared with register physical address. If there > > > > are more than 2 slots, compared logic will become complex. > > > > > > > > "linux,pci-domain" already exist at dts since commit: > > > > commit (c0b70f05c87f3b arm64: dts: imx8mq: use_dt_domains for pci node). > > > > > > > > So it is safe to remove compare basic address code: > > > > ... > > > > if (dbi_base->start == IMX8MQ_PCIE2_BASE_ADDR) > > > > imx6_pcie->controller_id = 1; > > > > > > No it is not unless you magically update all firmware out > > > there in the field. > > > > commit c0b70f05c87f3b09b391027c6f056d0facf331ef > > Author: Peng Fan <peng.fan@xxxxxxx> > > AuthorDate: Fri Jan 15 11:26:57 2021 +0800 > > Commit: Shawn Guo <shawnguo@xxxxxxxxxx> > > CommitDate: Fri Jan 29 14:46:28 2021 +0800 > > > > I am not sure if it is neccesary to compatible with 2 years ago's dts. > > I think it may not boot at all with using 2 year agao dtb file directly. > > > > Do you have other comments? I can remove it from this big patch series, > > I will have a look at the full series first we can decide whether > to drop it later. > > I am travelling so I am not sure I can review it before February > 12th, FYI. Okay, I send v10 at https://lore.kernel.org/imx/Zb06JL5X8EiHEyFD@lpieralisi/raw which removed "linux,pci-domain" patches. If you have more comments, please comment at v10 version. Frank > > Lorenzo
