Re: [PATCH 1/4] PCI: qcom: Reshuffle reset logic in 2_7_0 .init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 29.12.2023 16:46, Bjorn Helgaas wrote:
> On Fri, Dec 29, 2023 at 03:04:23PM +0100, Johan Hovold wrote:
>> On Wed, Dec 27, 2023 at 11:17:19PM +0100, Konrad Dybcio wrote:
>> ...
> 
>> This is arguably a separate change, and not necessarily one that is
>> correct either, so should at least go in a separate patch if it should
>> be done at all.
> 
> A nice side effect of splitting might be that it would be a chance to
> put a little more specific information in the subject lines.
> "Reshuffle reset logic" by itself doesn't connect it to a specific
> issue or reason for the change.
Yes, sorry, that's on me.

I've been deep inside this topic recently and many things on the QC
side are quite obvious to me, but I often keep forgetting that I
need to externalize that knowledge in commit messages properly..

Konrad




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux