> On Dec 28, 2023, at 3:56 PM, Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > > [+to Daniel, can you take a look? If you like this, I'd like to > squash it into df25461119d9 and credit Christophe since that's not > upstream yet] Thanks very much for fixing this, Christophe. The fix looks correct to me. If it can still fold into the previous change, all the better. Best, Daniel PS: without trying to complicate this thread, does one know idr.[ch] well enough to state whether ida_free() could have gone into stdev_release()? The way the two idr_free calls have been placed looks intentional. But stdev_release would look more obvious + cleaner to me. Was only starting to wonder while reviewing the err_put side of this patch.
