On 26/12/2023 22:53, Frank Li wrote: >>> DTB_CHECK report error after I remove it. linux,pci-domain is only define >>> in pci, not pci-ep. >> >> Ah, thank you, indeed. >> >>> >>> So I add comments about this. linux,pci-domain was resued ad controller id. >> >> However maybe there is reason why it is not for endpoints. The >> description is saying it is valid only for host bridge, so maybe it >> should not be used for endpoint case? > > EP side, it is not PCI bus. So it is reasonable that linux,pci-doamin not > in EP side. > > iMX6 host driver(and other some host controller drivers) already use it as > "controller id". EP driver is mostly reused with host bridge drivers. I > think needn't create new property such as "controller_id" for EP only. > > A comments should be enough for this case. Hm, ok, seems fine for me. I don't know PCI good enough to judge, so unless Rob or Conor say something else, it looks good. Best regards, Krzysztof
