On Tue, Dec 26, 2023 at 08:01:53PM +0100, Krzysztof Kozlowski wrote: > On 26/12/2023 17:12, Frank Li wrote: > > On Mon, Dec 25, 2023 at 08:16:17PM +0100, Krzysztof Kozlowski wrote: > >> On 24/12/2023 19:32, Frank Li wrote: > >>> Add i.MX95 PCIe "fsl,imx95-pcie-ep" compatible string. > >>> Add reg-name: "atu", "dbi2", "dma" and "app". > >>> Reuse PCI linux,pci-domain as controller id at endpoint. > >>> > >>> Signed-off-by: Frank Li <Frank.Li@xxxxxxx> > >>> --- > >>> > >> > >> ... > >> > >>> +# reuse PCI linux,pci-domain as controller id at Endpoint > >>> + - if: > >>> + properties: > >>> + compatible: > >>> + enum: > >>> + - fsl,imx95-pcie-ep > >>> + then: > >>> + properties: > >>> + linux,pci-domain: true > >> > >> Same comment: why do you need? Don't ignore my feedback. You responded > >> you will fix it, but it is still here... > > > > DTB_CHECK report error after I remove it. linux,pci-domain is only define > > in pci, not pci-ep. > > Ah, thank you, indeed. > > > > > So I add comments about this. linux,pci-domain was resued ad controller id. > > However maybe there is reason why it is not for endpoints. The > description is saying it is valid only for host bridge, so maybe it > should not be used for endpoint case? EP side, it is not PCI bus. So it is reasonable that linux,pci-doamin not in EP side. iMX6 host driver(and other some host controller drivers) already use it as "controller id". EP driver is mostly reused with host bridge drivers. I think needn't create new property such as "controller_id" for EP only. A comments should be enough for this case. Frank > > > > If include pci.yaml, there are too much other properties was involved, but > > not used by pci-ep. > > Best regards, > Krzysztof >
