Re: [PATCH v8 0/2] PCI: brcmstb: Configure appropriate HW CLKREQ# mode

Florian Fainelli <florian.fainelli@xxxxxxxxxxxx> · Tue, 12 Dec 2023 15:51:12 -0800

On 11/26/23 12:19, Cyril Brulebois wrote:
Hi Jim,

Jim Quinlan <james.quinlan@xxxxxxxxxxxx> (2023-11-13):
V8 -- Un-advertise L1SS capability when in "no-l1ss" mode (Bjorn)
    -- Squashed last two commits of v7 (Bjorn)
    -- Fix DT binding description text wrapping (Bjorn)
    -- Fix incorrect Spec reference (Bjorn)
          s/PCIe Spec/PCIe Express Mini CEM 2.1 specification/
    -- Text substitutions (Bjorn)
          s/WRT/With respect to/
          s/Tclron/T_CLRon/

v7 -- Manivannan Sadhasivam suggested (a) making the property look like a
       network phy-mode and (b) keeping the code simple (not counting clkreq
       signal appearances, un-advertising capabilites, etc).  This is
       what I have done.  The property is now "brcm,clkreq-mode" and
       the values may be one of "safe", "default", and "no-l1ss".  The
       default setting is to employ the most capable power savings mode.

Still:

Tested-by: Cyril Brulebois <cyril@xxxxxxxxxxx>

Thanks Cyril! Bjorn, Lorenzo, any chance this can be applied soon? Thanks!
--
Florian

Attachment:
smime.p7s

Description: S/MIME Cryptographic Signature