On Tue, Dec 12, 2023 at 04:44:26PM -0600, Rob Herring wrote: > On Mon, Dec 11, 2023 at 04:58:37PM -0500, Frank Li wrote: > > From: Richard Zhu <hongxing.zhu@xxxxxxx> > > > > Add i.MX95 PCIe "fsl,imx95-pcie" compatible string. > > Add "atu" and "serdes" to reg-names. > > > > Signed-off-by: Richard Zhu <hongxing.zhu@xxxxxxx> > > --- > > > > Notes: > > Change from v2 to v3 > > - Remove krzy's ACK tag > > - Add condition check for imx95, which required more reg-names then old > > platform, so need Krzy review again, > > > > Change from v1 to v2 > > - add Krzy's ACK tag > > > > .../bindings/pci/fsl,imx6q-pcie.yaml | 18 ++++++++++++++++++ > > 1 file changed, 18 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > index 81bbb8728f0f9..b8fcf8258f031 100644 > > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > @@ -29,6 +29,7 @@ properties: > > - fsl,imx8mq-pcie > > - fsl,imx8mm-pcie > > - fsl,imx8mp-pcie > > + - fsl,imx95-pcie > > > > reg: > > items: > > @@ -90,6 +91,22 @@ required: > > allOf: > > - $ref: /schemas/pci/snps,dw-pcie.yaml# > > - $ref: /schemas/pci/fsl,imx6q-pcie-common.yaml# > > + - if: > > + properties: > > + compatible: > > + enum: > > + - fsl,imx95-pcie > > + then: > > + properties: > > + reg: > > + minItems: 4 > > + reg-names: > > + items: > > + - const: dbi > > + - const: serdes > > Did you test this? It should fail because 'serdes' would need to be > added to snps,dw-pcie.yaml. I run "make dt_binding_check DT_SCHEMA_FILES=/pci/", no error report. And PCIe function can work. > > Is this really not a separate phy block? This is misc block, which included phy and also include some registers about SID for each PCI devices. I plan do it later. > A separate node would be > ideal. If not, there's already a 'phy' name you can use here. We don't > want more random names. Chip reference manual call it as 'serdes'. If there are already similar name, I can reuse it. > > Rob
